Allow dark scrollbars to use theme colors.
Categories
(Core :: Widget: Gtk, defect)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox99 | --- | fixed |
People
(Reporter: emilio, Assigned: emilio)
References
Details
(Keywords: perf-alert)
Attachments
(3 files)
Follow-up from bug 1753830 since this was a bit drive-by. We're extracting dark colors from GTK already, so we can do this if we want, and this makes the scrollbar drawing code more straight-forward.
|
Assignee | |
Comment 1•2 years ago
|
||
This is faster and more straight-forward code than the old
ShouldUseDarkScrollbar shenanigans, and allows to have dark-themed
scrollbars.
|
|
Assignee | |
Comment 2•2 years ago
|
||
Drive-by but we can do this now that this code is not needed by
nsNativeThemeCocoa (bug 1749531).
Depends on D138077
|
||
Comment 3•2 years ago
|
||
Comment on attachment 9262858 [details]
Bug 1754225 - Move a bunch of cocoa-specific scrollbar code to ScrollbarDrawingCocoa.cpp. r=spohl,mstange
Revision D138083 was moved to bug 1753830. Setting attachment 9262858 [details] to obsolete.
|
|
||
Updated•2 years ago
|
|
|
Assignee | |
Comment 4•2 years ago
|
||
Use LayoutDeviceRect consistently, and add default initializers.
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/341e55a2529a Allow using dark themed scrollbars on GTK too. r=stransky,mstange https://hg.mozilla.org/integration/autoland/rev/ac1b0f5f0990 Move a bunch of cocoa-specific scrollbar code to ScrollbarDrawingCocoa.cpp. r=mstange https://hg.mozilla.org/integration/autoland/rev/1aaaab4dd5d3 Some more trivial clean-ups to the cocoa scrollbar drawing code. r=mstange
|
||
Comment 6•2 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/341e55a2529a
https://hg.mozilla.org/mozilla-central/rev/ac1b0f5f0990
https://hg.mozilla.org/mozilla-central/rev/1aaaab4dd5d3
|
||
Comment 7•2 years ago
|
||
== Change summary for alert #33224 (as of Thu, 10 Feb 2022 22:45:44 GMT) ==
Improvements:
| Ratio | Test | Platform | Options | Absolute values (old vs new) |
|---|---|---|---|---|
| 30% | bing ContentfulSpeedIndex | android-hw-p2-8-0-android-aarch64-shippable-qr | warm webrender | 423.25 -> 295.17 |
| 19% | bing ContentfulSpeedIndex | android-hw-g5-7-0-arm7-shippable-qr | warm webrender | 610.17 -> 497.08 |
| 15% | bing ContentfulSpeedIndex | android-hw-p2-8-0-android-aarch64-shippable-qr | cold webrender | 823.42 -> 701.92 |
| 9% | bing ContentfulSpeedIndex | android-hw-g5-7-0-arm7-shippable-qr | cold webrender | 1,197.00 -> 1,089.67 |
For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=33224
|
|
||
Updated•2 years ago
|
Description
•